Skip to content

ci: force Windows Git version to 2.22.0#3833

Merged
bk2204 merged 1 commit intogit-lfs:masterfrom
bk2204:fix-windows-ci
Sep 26, 2019
Merged

ci: force Windows Git version to 2.22.0#3833
bk2204 merged 1 commit intogit-lfs:masterfrom
bk2204:fix-windows-ci

Conversation

@bk2204
Copy link
Member

@bk2204 bk2204 commented Sep 23, 2019

In Git for Windows 2.23, the /dev and /dev/fd directories did not get created. As a result, it's not possible to use a process substitution in bash, which breaks a significant portion of the test suite. In the mean time, let's downgrade Git for Windows to 2.22.0, which is what Actions used to use and worked for us. We can remove this hack when the next Git for Windows release occurs.

Fixes #3828.

@bk2204 bk2204 force-pushed the fix-windows-ci branch 2 times, most recently from a2acb57 to e98381d Compare September 23, 2019 15:39
In Git for Windows 2.23, the /dev and /dev/fd directories did not get
created.  As a result, it's not possible to use a process substitution
in bash, which breaks a significant portion of the test suite.  In the
mean time, let's downgrade Git for Windows to 2.22.0, which is what
Actions used to use and worked for us.  We can remove this hack when the
next Git for Windows release occurs.
@bk2204 bk2204 marked this pull request as ready for review September 23, 2019 16:16
@slonopotamus
Copy link
Contributor

Interesting. Is there a bugreport/fix for this in Git for Windows? I just want to make sure that subsequent Git for Windows releases will actually fix things back.

@slonopotamus
Copy link
Contributor

Found it: git-for-windows/git#2291

@bk2204 bk2204 requested a review from a team September 26, 2019 13:25
Copy link
Contributor

@PastelMobileSuit PastelMobileSuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bk2204 bk2204 merged commit 6de0a46 into git-lfs:master Sep 26, 2019
@bk2204 bk2204 deleted the fix-windows-ci branch September 26, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests do not pass on Windows CI

3 participants