Conversation
Per [1], we would like to build Git LFS on Go version 1.11, following testing over several weeks. As is done in [2], let's upgrade the version of Go used in continuous integration (particularly on AppVeyor and CircleCI) to match. Since Chocolatey has not yet shipped Go 1.11 on their default channel, we'll continue to download the binary ourselves manually. Once the desired version of Go is available, this should be upgraded, too. Notably, this change does not include Go Module support (as introduced in version 1.11), so the value for $GO111MODULE is left unset, as to avoid breaking existing checkouts of Git LFS that reside in a $GOPATH. A subsequent change will introduce Go Module support, at which point existing check-outs of Git LFS will need to be relocated. [1]: build-dockers@46040a6 (all: build against Go 1.11, 2018-08-28) [2]: d4df80b ({.travis,appveyor}.yml: upgrade to Go 1.10.3, 2018-07-25) Co-authored-by: brian m. carlson <bk2204@github.com>
6f412cb to
074a2d4
Compare
bk2204
approved these changes
Aug 29, 2018
Member
bk2204
left a comment
There was a problem hiding this comment.
This looks good to me. I don't see any more references to 1.10 anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per 1, we would like to build Git LFS on Go version 1.11, following
testing over several weeks. As is done in 2, let's upgrade the version
of Go used in continuous integration (particularly on AppVeyor and
CircleCI) to match.
Since Chocolatey has not yet shipped Go 1.11 on their default channel,
we'll continue to download the binary ourselves manually. Once the
desired version of Go is available, this should be upgraded, too.
Notably, this change does not include Go Module support (as introduced
in version 1.11), so the value for $GO111MODULE is left unset, as to
avoid breaking existing checkouts of Git LFS that reside in a $GOPATH. A
subsequent change will introduce Go Module support, at which point
existing check-outs of Git LFS will need to be relocated.
/cc @git-lfs/core