Skip to content

Fixed detection of LocalGitDir within submodules#312

Merged
technoweenie merged 1 commit intogit-lfs:masterfrom
michael-k:panic-fix
May 21, 2015
Merged

Fixed detection of LocalGitDir within submodules#312
technoweenie merged 1 commit intogit-lfs:masterfrom
michael-k:panic-fix

Conversation

@michael-k
Copy link
Contributor

Fixes #310

filepath.Abs() created absDir based on the current working directory.

@aorjoa
Copy link
Contributor

aorjoa commented May 17, 2015

👍

@technoweenie
Copy link
Contributor

Thanks! We'll get this in for the next release. I'm hoping I can get my new test suite merged so we can test it too (#306).

This was referenced May 18, 2015
@technoweenie technoweenie merged commit 6d343ba into git-lfs:master May 21, 2015
@technoweenie
Copy link
Contributor

Here's the test I wrote for this: https://github.com/github/git-lfs/blob/09f72a4ff746810c741ea2c19ad4518556dff61c/test/test-submodule.sh

Thanks again for the report and fix 🤘

@michael-k michael-k deleted the panic-fix branch May 21, 2015 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic trying to track file from within subdirectory of submodule

3 participants