Merged
Conversation
9 tasks
ttaylorr
approved these changes
Jan 6, 2018
Contributor
ttaylorr
left a comment
There was a problem hiding this comment.
These changes look great to me! I have a few minor comments, but this 👀 ready to go from my perspective.
| verifyLocksForUpdates(ctx.lockVerifier, updates) | ||
| for _, update := range updates { | ||
| q := ctx.NewQueue() // initialized here to prevent looped defer | ||
| q := ctx.NewQueue( // initialized here to prevent looped defer |
Contributor
There was a problem hiding this comment.
Nit: should this comment be moved to the line above? I think if we ever add arguments to this method, it will help keep the lines short.
Contributor
Author
There was a problem hiding this comment.
Yeah I suppose. The comment could be moved when the first comment is added.
|
|
||
| refute_server_object "$reponame" 98ea6e4f216f2fb4b69fff9b3a44842c38686ca685f3f55dc48c5d3fb1107be4 "refs/heads/tracked" | ||
|
|
||
| # for some reason, using 'tee' and $PIPESTATUS does not work here |
Contributor
There was a problem hiding this comment.
I believe that `${PIPESTATUS[1]} would work, since there are two commands being piped here.
Contributor
Author
There was a problem hiding this comment.
That must be copy pasta, I don't recall any issues. At any rate, it's just a test so it doesn't matter ;)
|
|
||
| # for some reason, using 'tee' and $PIPESTATUS does not work here | ||
| set +e | ||
| echo "refs/heads/master master refs/heads/master 0000000000000000000000000000000000000000" | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2806, finally teaching the
tq.TransferQueueto pass on the refspec to the server.