Closed
Conversation
Contributor
|
❄️ per #2712 (comment). |
This was referenced Jan 4, 2018
Contributor
Author
|
Closing this due to conflicts. See #2806. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2712 for Batch API calls.
There is a problem here though. Currently, Transfer Queues and Git Scanners are scoped for a single remote. The updated
newUploadQueue()builds a new Transfer Queue with the current remote ref.That's fine, except the
pre-pushhook is called with the correct remote ref, and it supports multiple refs.This should be calling
objects/batchat least once for each ref. I made some changes tocommands/uploader.goto initialize a new Transfer Queue and Git Scanner, but ran into a deadlock issue deep in the Git Scanner.