Skip to content

commands: teach smudge, process-filter to warn about Windows size bug#2459

Merged
ttaylorr merged 3 commits intomasterfrom
windows-size-warning
Jul 31, 2017
Merged

commands: teach smudge, process-filter to warn about Windows size bug#2459
ttaylorr merged 3 commits intomasterfrom
windows-size-warning

Conversation

@ttaylorr
Copy link
Contributor

This pull request teaches the git lfs {smudge,filter-process} commands to warn when smudging blobs larger than 4 GB on Windows.

From #2434 (comment):

[...] I ran this by a Git core dev, and he mentioned that Git on Windows does not support files over 4GB. Unfortunately, this is not something we can fix in LFS. The best we can do now add a warning when large objects are added.

This pull request adds that warning.

Here's a quick breakdown of how things happened:

  1. 3a080f9: teach smudge() (et. al.) to return (int64, error) as io.Copy does, to indicate the number of bytes smudged by a call to that function.
  2. f6beec6: use the return value from that function to determine and potentially warn about files larger than 4gb being copied into the worktree.

@technoweenie also mentioned:

[...] I think we should add an early warning in the filter smudge and process code, perhaps linking to a page offering this workaround.

I originally added a link back to #2434, but thought that adding a section to the manpage would be sufficient, and perhaps a little cleaner, since the manpages are distributed in the binary and don't require you to be online to view them.

Closes: #2434.


/cc @git-lfs/core
/cc #2434

@ttaylorr ttaylorr added this to the v2.3.0 milestone Jul 31, 2017
@ttaylorr ttaylorr requested a review from rubyist July 31, 2017 19:03
@ttaylorr ttaylorr merged commit 54c01db into master Jul 31, 2017
@ttaylorr ttaylorr deleted the windows-size-warning branch July 31, 2017 19:24
@ThoonsanEain
Copy link

#4940

@ThoonsanEain
Copy link

#4840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Git on Windows client corrupts files > 4Gb

3 participants