commands: teach smudge, process-filter to warn about Windows size bug#2459
Merged
commands: teach smudge, process-filter to warn about Windows size bug#2459
Conversation
rubyist
approved these changes
Jul 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request teaches the
git lfs {smudge,filter-process}commands to warn when smudging blobs larger than 4 GB on Windows.From #2434 (comment):
This pull request adds that warning.
Here's a quick breakdown of how things happened:
smudge()(et. al.) to return(int64, error)asio.Copydoes, to indicate the number of bytes smudged by a call to that function.@technoweenie also mentioned:
I originally added a link back to #2434, but thought that adding a section to the manpage would be sufficient, and perhaps a little cleaner, since the manpages are distributed in the binary and don't require you to be online to view them.
Closes: #2434.
/cc @git-lfs/core
/cc #2434