Conversation
peff
reviewed
Jun 19, 2017
peff
left a comment
There was a problem hiding this comment.
FWIW, this looks fine from the Git side.
git/git.go
Outdated
| // those references could not be loaded. | ||
| func AllRefs() ([]*Ref, error) { | ||
| cmd := subprocess.ExecCommand("git", | ||
| "for-each-ref", "--format='%(objectname)%00%(refname)'") |
There was a problem hiding this comment.
Using a NUL here is probably overkill. The objectname can't have any whitespace in it. It looks like splitting on NUL isn't any harder, so it's fine as an extra precaution.
The entries are still delimited by newlines, but that's OK, as newlines are forbidden in refnames.
technoweenie
approved these changes
Jun 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request teaches a new function to the
gitpackage,AllRefs()which returns a listing of all references in a repository.This is required for the
importsubcommand ofgit-lfs-migrate(1)which needs a listing of all references in order to move references from the old graph onto the migrated one. Ideally this could come fromgit-rev-list(1)(which we already run to generate a listing of commits to migrate), but tricking the output to be machine readable is difficult to do without switching togit-log, which doesn't have great machine-readable output either./cc @git-lfs/core
/cc #2146