git/githistory/log: teach Durable() to Task#2334
Conversation
|
Why is this needed? If the tasks need to be durable, then they probably don't need to be throttled in the first place. Do only some of the tasks need this? |
Good question 😄 Only some of the tasks need this. For instance, the |
|
Ah, that makes sense after looking at that PR. I would just add |
Thanks for taking a look, and sorry for not explaining things more thoroughly in this PR.
Good call, I like the explicitness of being able to declare that a task is
I think I prefer the |
|
I just don't think |
technoweenie
left a comment
There was a problem hiding this comment.
Still don't like Durable(), as it's not losing data.
Another idea is something like RefreshRate() time.Duration, so tasks can specify their own update frequency.
That said, keep on rocking with Durable if you like.
This pull request teaches a new
Tasktype to thegithub.com/git-lfs/git-lfs/git/githistory/logpackage:DurableTask.A
DurableTaskensures that all log<-Update()reads are logged to thesink io.Writer, regardless of throttling conditions. This required for multi-line log updates (like output fromgit-ref-update(1)) where all log lines are important./cc @git-lfs/core
/refs #2146 #2329