Conversation
technoweenie
approved these changes
Apr 26, 2017
Contributor
technoweenie
left a comment
There was a problem hiding this comment.
I think this is a good approach, consistent with the change to use %+v in the error log files in #2178.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the first concern raised in #2076:
I was looking into the cause of this and found that the callsites in question were using the function
commands.LoggedError(), which has the signature:What this does is effectively:
fmt.Fprintf(os.Stderr, format, args...), (write the format string to stderr) andLogError(os.File, err)(log the error togit lfs logs last)Notably, this function does not print the error to stderr unless specified with the format string and arguments. Something like this would look like:
I think this is good behavior, since different functions will want to format errors differently. That being said, I looked at all of the callers of
LoggedErrorand updated them to include the error that they are logging using the%sformat, which iscause: errorwithout a stacktrace. This should better surface errors that were previously only accessible via agit lfs logs last, and will resolve #2076.Closes #2076.
/cc @git-lfs/core @JarrettR #2076