Merged
Conversation
ttaylorr
approved these changes
Jan 6, 2017
Contributor
ttaylorr
left a comment
There was a problem hiding this comment.
Looks good, just one minor nit which you can feel free to ignore. These tests look awesome, and very comprehensive 👍
test/test-batch-transfer.sh
Outdated
| git config lfs.url "$sshurl" | ||
| git lfs env | ||
|
|
||
| oid="$(calc_oid "test")" |
Contributor
There was a problem hiding this comment.
Nit: if you want, I thinking naming this with a $contents variable would be consistent with the rest of the test suite and bring some additional clarity:
contents="test"
oid="$(calc_oid "$contents")"
printf "$contents" > test.dat
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports SSH auth from the old httputil package. Uses the integration test added in #1825.