Skip to content

Api/tq manifest#1826

Closed
technoweenie wants to merge 7 commits intoapi/lockingfrom
api/tq-manifest
Closed

Api/tq manifest#1826
technoweenie wants to merge 7 commits intoapi/lockingfrom
api/tq-manifest

Conversation

@technoweenie
Copy link
Contributor

@technoweenie technoweenie commented Jan 4, 2017

This breaks the tq.Manifest constructor, so that it accepts an *lfsapi.Client instance. This is how transfer queue and adapters get access to the *lfsapi.Client to make API requests. It also removes some references to the CurrentRemote property on *config.Configuration objects. Since the *lfsapi.Client already has os and git env objects, there's no need to pass them in manually.

I'm not totally sold on whether the manifest constructor should accept operation and remote strings, vs just an access string. I think a future change could remove the need for both values, leaving us with a single NewManifest(c *lfsapi.Client) constructor.

TODO:

@technoweenie technoweenie mentioned this pull request Jan 4, 2017
2 tasks
@technoweenie
Copy link
Contributor Author

I hated the new tq.Manifest constructors, so I removed all the arguments except the *lfsapi.Client in #1827.

@technoweenie technoweenie deleted the api/tq-manifest branch January 4, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant