Merged
Conversation
Contributor
Author
|
@ttaylorr I got rid of the |
… current endpoint
Contributor
|
Great, isolating the config into a pure data-carrier per package that's populated by the reflection stuff feels way more robust than mixing that in other types. |
ttaylorr
approved these changes
Dec 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly different approach to #1766. Instead of introducing a new
tq.WithGitEnv()option, this assumes that the caller will configure the*tq.Manifest, which is now a required argument forNewTransferQueue(). I was able to remove allconfigreferences inside thetqpackage except for the internal uses (which is tied to internal api methods still using it). Nothing in the exported interface usesconfiganymore though.I like this approach, it gets us closer to @sinbad's idea of a config object per package. Could even rename
*tq.Manifestto*tq.Configif you think that'd make more sense.Notes:
Had to export-- not the case, see belowBasicTransfersOnlyandTusTransfersAllowedallowed, becauseUnmarshal()can only set exported properties. I'd rather not export these though.NewDownloadCheckQueuein https://github.com/git-lfs/git-lfs/pull/1746/files#diff-1b73a9b301d9b5f76392f5818dd2ab15L43, it was re-added.ConcurrentTransfers()call too.