Locking: move lock funcs to own package#1723
Merged
Merged
Conversation
technoweenie
approved these changes
Nov 29, 2016
technoweenie
left a comment
Contributor
There was a problem hiding this comment.
I'm approving this on the condition that the locking exports are changed as suggested (#1625 (comment)) in a future PR. Since it's going to locking-master, it should unblock you until you're ready to merge to master.
Contributor
Author
Yeah, I think that's going to need a bigger refactor of other code's use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementation of #1625. Based on PR feedback (except config changes which are still pending). Channel wrappers are gone & so is much of complexity, simpler for clients (and added local
Lockstruct so remove dependency onapi.Lock).Merge target is
locking-masterto denote that this isn't a finished API yet but to enable reviewing in bite-size chunks.