Merged
Conversation
| tar -c . --exclude tmptar --exclude repos | tar -x -C ${CURDIR}/tmptar/git-lfs-${LFS_VERSION}/ | ||
| popd | ||
| pushd ${CURDIR}/tmptar/git-lfs-${LFS_VERSION} | ||
| git clean -xdf |
Contributor
There was a problem hiding this comment.
If I remember correctly the only reason the git clean was needed was to remove any untracked files that were in your working copy when running the scripts. So this is definitely NOT needed, just FYI
Contributor
|
In accordance with git-lfs/build-dockers#3 (comment), 👍 . |
Contributor
Author
|
@andyneff Thanks, I've made a note of that. I'm going to merge this now so we can get LFS v1.3 out the door, but I think there are more opportunities to clean the scripts up even more. I plan on opening an issue with some TODOs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the debian and rpm build scripts to go with git-lfs/build-dockers#3.
/cc @andyneff