Skip to content

Harden pointer parsing #3865

@bk2204

Description

@bk2204

Currently, our pointer parsing is a bit too generous. We accept carriage returns as well as files with an explicit size of zero. Neither one of these is conformant with the spec, and accepting them leads to round-tripping problems, since multiple files can represent the same object. This leads to Git showing the file as changed in some cases.

We should reject both of these cases and add tests for handling them (as well as empty files) appropriately.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions