Inconsistent file mode bits when creating directories #363
Description
I noticed, that we're inconsistent regarding the file mode bits when creating directories. We use 0774, 0744, and 0755.
I guess it should all be 0755? (This is what git uses in git init.)
The search result shows, that for lfs.LocalLogDir and lfs.TempDir os.MkdirAll gets called with different file mode bits:
zsh$ grep -i "Mkdir.*07[0-7][0-7]" **/*.go
commands/commands.go: if err := os.MkdirAll(lfs.LocalLogDir, 0755); err != nil {
lfs/lfs.go: if err := os.MkdirAll(TempDir, 0774); err != nil {
lfs/lfs.go: if err := os.MkdirAll(path, 0744); err != nil {
lfs/lfs.go: if err := os.MkdirAll(LocalMediaDir, 0744); err != nil {
lfs/lfs.go: if err := os.MkdirAll(LocalLogDir, 0744); err != nil {
lfs/lfs.go: if err := os.MkdirAll(TempDir, 0744); err != nil {
lfs/setup.go: if err := os.MkdirAll(filepath.Join(LocalGitDir, "hooks"), 0755); err != nil {
lfs/util.go: if err := os.MkdirAll(cbDir, 0755); err != nil {
script/build.go: err := os.MkdirAll(dir, 0755)
vendor/_nuts/github.com/technoweenie/go-contentaddressable/file.go: if err := os.MkdirAll(dir, 0755); err != nil {