Use node-fetch for fetchJSONFromURL#11
Merged
dscho merged 3 commits intogit-for-windows:mainfrom Feb 18, 2021
Merged
Conversation
Member
Ironically, I did use it originally. But I was wary of adding yet more stuff that I do not really need. Could you add an |
dscho
requested changes
Feb 18, 2021
Member
|
I only reordered the commits so that |
Member
|
Oh, completely forgot: thank you so much! |
Member
|
@dennisameling look at this beauty: https://github.com/marketplace/actions/setup-git-for-windows-sdk |
Contributor
Author
|
Love it!! 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in git-for-windows/git#3040 (comment):
Actually, using
node-fetchis a lot easier in this case. It makes mocking much easier as well. It's a very lightweight package that also adds convenience methods likeres.json()to parse JSON responses.