Skip to content

Conversation

@ldennington
Copy link
Contributor

Changes:

mjcheetham and others added 18 commits August 1, 2023 09:37
Since GCM 2.1, we are using a newer version of MSAL that uses the new
MSAL runtime that solves the COM security issues that presented with
elevated processes.

Update our documentation to recommend people update to fix this problem.
When you sign-in with an MSA using WAM you are asked if you wish to use
this account "everywhere on your device", or just "Microsoft apps only".
The former will connect your local user account to an MSA, and the
latter will not.

Clarify the docs around this, including an annotated image of the
specific diaglog.
In GCM 2.3 we dropped the symlinks.
Let's update our docs on the issue to reflect this.
Co-authored-by: Lessley Dennington <ldennington@github.com>
Co-authored-by: Lessley Dennington <ldennington@github.com>
When you sign-in with an MSA using WAM you are asked if you wish to use
this account "everywhere on your device", or just "Microsoft apps only".
The former will connect your local user account to an MSA, and the
latter will not. Clarify the docs around this, including an annotated
image of the
specific dialog.

In addition, since GCM 2.1, we are using a newer version of MSAL that
uses the new MSAL runtime that solves the COM security issues that
presented with elevated processes. Update our documentation to recommend
people update to fix this problem.

Fixes #1355

Rendered:
https://github.com/mjcheetham/git-credential-manager/blob/wam-doc-update/docs/windows-broker.md
In GCM 2.3 we dropped the symlinks.
Let's update our docs on the issue to reflect this.

Rendered:
https://github.com/git-ecosystem/git-credential-manager/blob/rename-docs-update/docs/rename.md
Add an entry in the FAQs about what the `configure` and `unconfigure`
commands actually do to your Git configuration.
Add an entry in the FAQs about what the `configure` and `unconfigure`
commands actually do to your Git configuration.

Fixes #1357
If may be possible for multiple credentials for the same user account to
exist in any credential store. To avoid issues with redundant account
selection prompts we should ensure duplicate accounts are removed from
the results of `ICredentialStore.GetAccounts`.

Call `.Distinct()` or use a `HashSet` where appropriate on all
implementation of `ICredentialStore.GetAccounts`.
If may be possible for multiple credentials for the same user account to
exist in any credential store. To avoid issues with redundant account
selection prompts we should ensure duplicate accounts are removed from
the results of `ICredentialStore.GetAccounts`.

Call `.Distinct()` or use a `HashSet` where appropriate on all
implementation of `ICredentialStore.GetAccounts`.

If there are multiple credentials for the same account, we'd only ever
be able to retrieve the first enumerated credential regardless because
our matching logic is to return to first credential that matches.

Fixes #1368
Add a section about how to set the default user globally for all repos in a particular host provider.
Add a section about how to set the default user globally for all repos
in a particular host provider.
GCM has migrated from the microsoft/homebrew-git tap to the
Homebrew/homebrew-cask tap. Updating the release-homebrew workflow to
publish new versions to the new tap.
GCM has migrated from the microsoft/homebrew-git tap to the
Homebrew/homebrew-cask tap. Updating the install instructions accordingly.
GCM has migrated from the `microsoft/homebrew-git` tap to the
`Homebrew/homebrew-cask` tap. This change contains two related updates:

1. The `release-homebrew` workflow now publishes to
`Homebrew/homebrew-cask`.
2. The docs now instruct users to install from the new tap.

The workflow updates were [tested in my
fork](https://github.com/ldennington/homebrew-cask/pull/5/files). There
is also a [corresponding PR in
`microsoft/homebrew-git`](microsoft/homebrew-git#73)
that will ensure users currently set up to upgrade from the
`microsoft/homebrew-git` tap will be automatically re-directed to
`Homebrew/homebrew-cask`.
@ldennington ldennington self-assigned this Aug 11, 2023
@ldennington ldennington merged commit 8064e2e into release Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants