fix(cli): ignore missing sections when removing configuration #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NG.md Change-Id: Ie21eb3761c8e632d1ff66c5b3fc2474f97e3364e
41b2ab5 to
c7e24ea
Compare
This change fixes an error typically encountered in the `git-bug-wipe` command, caused by overly zealous implementations of //repository:config.go%ConfigWrite.RemoveAll(). This change refactors these implementations to only attempt to remove sections that exist, and ignore non-existent sections. Closes: #1451 Change-Id: I66e710239915c8601dd70a78ae65eb625e093ef6
c7e24ea to
257ba78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an error typically encountered in the
git-bug-wipecommand, caused by overly zealous implementations of
//repository:config.go%ConfigWrite.RemoveAll(). This change refactors
these implementations to only attempt to remove sections that exist,
and ignore non-existent sections.
Closes: #1451
Change-Id: I66e710239915c8601dd70a78ae65eb625e093ef6