Fix PLAIN auth not working with passwords > 51 char#243
Merged
slonopotamus merged 1 commit intoMay 6, 2019
Conversation
Turns out, not all Base64 was born equal. RFC-4648 that we used, only allows strict Base64 alphabet in input string while RFC-2045 also allows whitespace, newlines and other funny stuff. And native Subversion sends \n for long logins/passwords Fixes git-as-svn#242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, not all Base64 was born equal. RFC-4648 that we used,
only allows strict Base64 alphabet in input string while RFC-2045 also
allows whitespace, newlines and other funny stuff. And native Subversion
sends \n for long logins/passwords
Fixes #242