Revert "fetch: default to protocol version 2"

jrn · gitster · commit 11c7f2a30b9d · 2020-04-22T11:37:44.000-07:00
This reverts commit 684ceae. Users fetching from linux-next and other kernel remotes are reporting that the limited ref advertisement causes negotiation to reach MAX_IN_VAIN, resulting in too-large fetches. Reported-by: Lubomir Rintel <lkundrak@v3.sk> Reported-by: "Dixit, Ashutosh" <ashutosh.dixit@intel.com> Reported-by: Jiri Slaby <jslaby@suse.cz> Reported-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/Documentation/config/protocol.txt b/Documentation/config/protocol.txt
@@ -48,7 +48,7 @@ protocol.version::
 	If set, clients will attempt to communicate with a server
 	using the specified protocol version.  If the server does
 	not support it, communication falls back to version 0.
-	If unset, the default is `2`.
+	If unset, the default is `0`.
 	Supported versions:
 +
 --
diff --git a/protocol.c b/protocol.c
@@ -39,7 +39,7 @@ enum protocol_version get_protocol_version_config(void)
 		return env;
 	}
 
-	return protocol_v2;
+	return protocol_v0;
 }
 
 enum protocol_version determine_protocol_version_server(void)

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ protocol.version::`
`48`	`48`	`If set, clients will attempt to communicate with a server`
`49`	`49`	`using the specified protocol version. If the server does`
`50`	`50`	`not support it, communication falls back to version 0.`
`51`		- If unset, the default is `2`.
	`51`	+ If unset, the default is `0`.
`52`	`52`	`Supported versions:`
`53`	`53`	`+`
`54`	`54`	`--`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ enum protocol_version get_protocol_version_config(void)`
`39`	`39`	`return env;`
`40`	`40`	`}`
`41`	`41`
`42`		`- return protocol_v2;`
	`42`	`+ return protocol_v0;`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`enum protocol_version determine_protocol_version_server(void)`