This repository was archived by the owner on May 15, 2025. It is now read-only.
Add a command line parameter to communicate back the email that user used for logging in#35
Merged
dkerwin merged 5 commits intogini:masterfrom Feb 10, 2020
andrewsav-bt:write-email
Merged
Add a command line parameter to communicate back the email that user used for logging in#35dkerwin merged 5 commits intogini:masterfrom andrewsav-bt:write-email
dkerwin merged 5 commits intogini:masterfrom
andrewsav-bt:write-email
Conversation
Contributor
|
@andrewsav-datacom How can we get this fixed? |
Contributor
|
@dkerwin sorry, I do not understand the question. The obvious answer is "by merging this PR". What's missing? |
Contributor
|
I'd really love to see you integrate the suggestion I made (replacing log.info + sprintf with log.infof). Besides that the PR looks fine. |
Contributor
|
Where can I see the suggestion? |
dkerwin
suggested changes
Feb 10, 2020
Contributor
dkerwin
left a comment
There was a problem hiding this comment.
Please fix the log.Info line
Co-Authored-By: Daniel Kerwin <daniel@linuxaddicted.de>
Contributor
|
@dkerwin I've made the change. |
dkerwin
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For integration of other internal tooling it is necessary to know which account was just added to
kubeconfigbydexter. Then other tooling may use this information to create, for example, a new context with that user inkubeconfig. Without this it is not possible to guess which of the accounts inkubeconfigwas just updated.This PR adds a new command line parameter
-fthat allows specifying a file name where dexter would write the email/identity/user just authenticated.