Fixed the Arduino component name for ESP-IDF.#300
Merged
gin66 merged 2 commits intogin66:masterfrom Dec 24, 2024
Merged
Conversation
Contributor
Author
|
The My dependencies:
espressif/arduino-esp32:
version: "*"
FastAccelStepper:
git: https://github.com/gin66/FastAccelStepper.git
version: masterChanging the Maybe I'm missing something obvious. @gagank1 do you have an idea whether this change is correct? |
Owner
|
For espidf-compilation without arduino, I use platformio and not the espressif toolchain directly. Any chance to provide a github action, which actually tests espidf compilation without platformio ? |
When using the library from ESP-IDF itself, the app sometimes hits a race condition where it reads _stepper from the StepperTask task before it's initialized. It's unclear why this happens when using ESP-IDF directly, and not when using Arduino.
Contributor
Author
|
Thank you for merging the PR. I'll take a stab at a GitHub action when I get the chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.