Skip to content

Add s390x cpu support to install.js and CI#412

Merged
giggio merged 2 commits intogiggio:mainfrom
linux-on-ibm-z:add_s390x_support
Jun 1, 2023
Merged

Add s390x cpu support to install.js and CI#412
giggio merged 2 commits intogiggio:mainfrom
linux-on-ibm-z:add_s390x_support

Conversation

@kun-lu20
Copy link
Contributor

@kun-lu20 kun-lu20 commented May 11, 2023

Currently node-chromedriver only supports Intel and ARM cpu. This PR aims to add s390x support to this repo and the CI pipeline.

kun-lu20 added 2 commits May 10, 2023 13:15
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
@giggio
Copy link
Owner

giggio commented May 11, 2023

This is cool, I'm on vacation now, I'll check it out as soon as I get some time, it'll be soon.

@kun-lu20
Copy link
Contributor Author

Thanks @giggio !

@stale stale bot added the wontfix label May 21, 2023
Repository owner deleted a comment from stale bot May 21, 2023
@giggio giggio merged commit c123b59 into giggio:main Jun 1, 2023
@giggio
Copy link
Owner

giggio commented Jun 1, 2023

I'll release 114.0.1 in a minute. Thanks, @kun-lu20 !

@kun-lu20
Copy link
Contributor Author

kun-lu20 commented Jun 1, 2023

Thank you so much @giggio !

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants