Skip to content

Fix AppVeyor CI#2111

Merged
giampaolo merged 3 commits intogiampaolo:masterfrom
mayeut:fix-python27
Jun 4, 2022
Merged

Fix AppVeyor CI#2111
giampaolo merged 3 commits intogiampaolo:masterfrom
mayeut:fix-python27

Conversation

@mayeut
Copy link
Copy Markdown
Contributor

@mayeut mayeut commented Jun 4, 2022

Summary

  • OS: Windows
  • Bug fix: yes
  • Type: scripts, tests, wheels
  • Fixes:

Description

Latest changes on master are failing on AppVeyor.

  1. ensure AppVeyor runs on changes in scripts/internal
  2. fix typo (missing comma) in scripts/internal/winmake.py
  3. disable flake8-bugbear on python < 3.5, it's not supported

mayeut added 3 commits June 4, 2022 13:45
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
@mayeut
Copy link
Copy Markdown
Contributor Author

mayeut commented Jun 4, 2022

@giampaolo, despite the failing check on issues workflow (which I have no idea how to fix), this is ready for review.

@giampaolo giampaolo merged commit 5ca6870 into giampaolo:master Jun 4, 2022
@giampaolo
Copy link
Copy Markdown
Owner

Thanks. Merged.

@mayeut mayeut deleted the fix-python27 branch July 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants