GTK: Search UI #9756
GTK: Search UI #9756
Conversation
| fn closureMatchLabel(_: *Self, selected: i64, total: i64) callconv(.c) ?[*:0]const u8 { | ||
| if (total <= 0) return glib.ext.dupeZ(u8, "0/0"); | ||
| var buf: [32]u8 = undefined; | ||
| const label = std.fmt.bufPrintZ(&buf, "{}/{}", .{ |
There was a problem hiding this comment.
This should ideally be localizable, but we can do that in a different PR
There was a problem hiding this comment.
I figured this was a safe one to avoid localization, but wouldn't surprise me to learn that x/y is not global lol.
There was a problem hiding this comment.
Yeah in some languages (e.g. Chinese) the order of x and y is reversed :) But again we can do this in another PR
9967521 to
c67bcf9
Compare
|
Going to send this so we have something in main. Happy to continue to address reviews with future PRs. |
|
Congrats on landing the feature we couldn't get from kovidgoyal/kitty#893 for 7 years! 🎉 |
|
Just a quick question, this is a feature I didn't realize was important but is very much so, and I'm glad to see it landing. however, it's not in a release yet right? It will land in 1.2.4 or 1.3.0? |
|
Correct. 1.3 slated for march. Complex features need time to bake |
|
👍 |
Fixes #189
This adds the UI for search to GTK. There is still polish to be done in follow-ups but this makes search work well with GTK to start!
AI disclosure: Believe it or not, almost this entire PR was AI-written. Amp did an excellent job looking at our existing codebase, comparing it to the macOS codebase, writing blueprint files, etc. I reviewed everything written, modified some basics, and verified it manually and under Valgrind.
Demo
Future Improvements