macOS Search GUI #9709
Merged
macOS Search GUI #9709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
@ftpd Sorry, this is not a place for discussion about future functionality. |
61eac0c to
c51170d
Compare
4ac8edb to
58296d5
Compare
58296d5 to
5b4394d
Compare
Contributor
Author
|
Broke my own rules with this one, but for AI disclosure: Amp was used for the GUI (visuals, not logic). I reviewed it all. Everything else is organic. |
Contributor
|
A few things I noticed (LMK if you prefer me opening new/separate discussions):
esc and cmd-shift-f are both bound to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#189 for macOS
This adds a search GUI for macOS, including macOS-standard menu bar items, and keybindings that match other native macOS applications such as Terminal app, Safari, and others. This introduces a new keybinding action
start_searchto start a blank search for GUIs.This PR also resolves a number of minor issues found in the search subsystem and renderer related to search from prior PRs. This should result in overall improved search stability. Please note there are still known issues (bottom of this PR).
Warning
A note on stability: I know a lot of people are eager to have this feature, and I'm excited
for this feature to soon be available in tip releases. But note that new features like this are
always filled with performance issues, bugs, crashes, etc. That's the point of tip releases:
to find and address these before wider availability. We will do our best to respond rapidly to
major issues found in tip, but don't expect perfect functionality immediately!
Demo
CleanShot.2025-11-25.at.22.18.58.mp4
Note
You can drag the search window to any of the four corners if its getting in the way of reading the terminal.
Known Issues
TODO prior to this PR merging:
ScreenSearchprunes history is fundamental unsafe. With a rapidly growing screen that could reach history limits and an active search at the same time, Ghostty is almost guaranteed to crash currently. The workaround is to not search actively scrolling screens (new data) for now.