refactor: load turnstile script manually#23
Merged
ghostdevv merged 1 commit intoghostdevv:mainfrom Jul 2, 2024
Merged
Conversation
Modifying script loading to accommodate the upcoming release of Svelte 5. The `on:load` event for scripts placed inside `<svelte:head>` does not fire in Svelte 5 as a result of this bug: sveltejs/svelte#8301 Instead of loading the Cloudfare Turnstile script in `<svelte:head>`, load the script dynamically during mount. This is functionally equivalent to using `<svelte:head>` but accommodates an operational load event handler. If Svelte 5 resolves Issue 8301, this is not needed.
|
Please merge this, thanks :) |
Owner
|
Thanks! Sorry for the delay 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #22
Modifying script loading to accommodate the upcoming release of Svelte 5. The
on:loadevent for scripts placed inside<svelte:head>does not fire in Svelte 5 as a result of this bug:sveltejs/svelte#8301
Instead of loading the Cloudfare Turnstile script in
<svelte:head>, load the script dynamically during mount. This is functionally equivalent to using<svelte:head>but accommodates an operational load event handler. If Svelte 5 resolves Issue 8301, this is not needed.This pull request can be reviewed on