This repository was archived by the owner on Jul 1, 2020. It is now read-only.
Added errorMessageVisible at updateErrorMsg#144
Merged
ghiscoding merged 1 commit intoghiscoding:masterfrom Jan 19, 2017
Gusi:errorMessageVisible
Merged
Added errorMessageVisible at updateErrorMsg#144ghiscoding merged 1 commit intoghiscoding:masterfrom Gusi:errorMessageVisible
ghiscoding merged 1 commit intoghiscoding:masterfrom
Gusi:errorMessageVisible
Conversation
Owner
|
is there a particular reason why you set it to |
Contributor
Author
|
I think that setting to undefined is better because as the value is not initialized at the constructor or so, the only possible values are "true" and "undefined". If you set to false, during the object lifecycle the possible values would be "true", "false" and "undefined" (before the updateErrorMsg is called) But at the end, it is a matter of personal preference :) |
Owner
|
Do you have to do a check if that property exist before looking at the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean variable to allow bootstrap decorator to monitor when the input is showing an error message.
#142