jsaddle-webkit2gtk: gi-gio 2.0.32 support#137
Merged
hamishmack merged 1 commit intoghcjs:masterfrom May 15, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons unknown to me, the type
AsyncReadyCallbackfromGI.Gio.Callbackchanged fromin gi-gio 2.0.30
in gi-gio 2.0.32, without a mention in the changelog. This came up during the update to webkit 2.40 in nixpkgs.
This patch fixes the build of jsaddle-webkit2gtk and I tested an application built with it.
I hope it’s not our job to somehow free the pointer I am ignoring here, but I don’t think so …
It is worth mentioning that
webViewRunJavascripthas a deprecation warning since webkit 2.40.I didn’t invest more effort in replacing that call since I am unclear what’s going to happen with jsaddle and the ghc new javascript backend.