PC-98 beep support #1806
Merged
PC-98 beep support #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I've applied your patch locally to test it. Still all beeps fine on qemu (from Debian) as well as on my 286-PC, @tyama501 ! +/* bell*/ missing a white space before the comment ends in |
Contributor
Author
|
Hi @floriangit Great! Thank you for quick testing! |
Owner
|
Hello @tyama501, This looks good. When you add the options for frequency and time, perhaps we can also use Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @ghaerr and @floriangit ,
I haven't added option to change the frequency and time,
but I have added the code for PC-98 according to
#1796
I could hear beep from PC-98 NekoProject/W emulator as below.
I also replaced IBM port numbers to defines of ports.h,
but I couldn't check it since my qemu on windows cannot enable speaker.
Could you double check it?
ELKS_PC98_beep_NP21W.mp4
Thank you!