[cmds] Speed up 'sl' - let her rip full speed #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts at "fixing"
slon very slow (8088) systems: discussed in #1619 (comment).slused to cursor position off the screen and continue to draw the entire train. All this output would all appear in the last screen column since an ANSI terminal clips cursor moves to the screen. On faster systems, such drawing wouldn't even be noticeable. Now, portions of the train not on the screen aren't drawn.After each column of the train was drawn,
slwould wait 40ms. On very fast systems, this slowed the train down as drawing was extremely quick. On slow systems, this had the effect of slowing the drawing down further. For the time being, this wait is turned off, pending @Vutshi's testing on the Book 8088 and Schneider systems. The proper fix involves timing each column display with millisecond accuracy, and only adding a delay for drawing that takes less than 40ms per cycle.