refactor(go bindings): thread safe contexts over whisper state#3419
Open
ciricc wants to merge 21 commits intoggml-org:masterfrom
Open
refactor(go bindings): thread safe contexts over whisper state#3419ciricc wants to merge 21 commits intoggml-org:masterfrom
ciricc wants to merge 21 commits intoggml-org:masterfrom
Conversation
…ded model context params, benchmarks, silence mode for the ggml
Contributor
|
FYI @aderbedr |
Contributor
|
Is it possible to do 97e6ce2 separately so it could be released sooner? |
Author
|
PR synced with upstream with new parameters. Benchmark command fixed, deleted diarization tests (required samples, diarization model ~500mb file downloaded). Sorry for such a big PR. It can be split, but I'm not sure it's necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Key changes
whisperCtxandwhisperStatepointers with lifecycle management.sync.Mapusage to be safe for parallel processing (since 59b3c47).Compatibility
Migration notes