fix: Add --jinja flag to granite-vision-3.2 test#24323
Closed
gabe-l-hart wants to merge 1 commit into
Closed
Conversation
Branch: GraniteVisionMTMDTests AI-usage: none Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
CISC
approved these changes
Jun 9, 2026
Collaborator
|
the response you mentioned doesn't seem quite right:
the correct answer must contain the word "new york", that was the case for granite before the change ; if it doesn't contains "new york", the test won't pass |
Collaborator
Author
|
@ngxson thanks for being diligent as always, and sorry to not give this better attention. I'll get to the bottom of it and make sure we've got a proper fix. |
Collaborator
Author
|
Ok, this wasn't the actual root of the issue. I've confirmed that #24357 fixes the behavior: $ ./build/bin/llama-mtmd-cli -hf ibm-research/granite-vision-3.2-2b-GGUF:Q4_K_M --image ./tools/mtmd/test-1.jpeg --temp 0 -n 128 --flash-attn on -p 'what is the publisher name of the newspaper?'
0.02.853.058 I common_init_result: fitting params to device memory ...
0.02.853.075 I common_init_result: (for bugs during this step try to reproduce them with -fit off, or provide --verbose logs if the bug only occurs with -fit on)
0.03.546.024 I common_init_from_params: warming up the model with an empty run - please wait ... (--no-warmup to disable)
0.03.576.776 I mtmd_cli_context: chat template example:
<|system|>
You are a helpful assistant<|user|>
Hello<|assistant|>
Hi there<|user|>
How are you?<|assistant|>
0.03.578.991 W load_tensors: ffn up/down are swapped
0.09.578.116 I main: loading model: /Users/ghart/.cache/huggingface/hub/models--ibm-research--granite-vision-3.2-2b-GGUF/snapshots/f5bf90fdfd834d3ea56ce8bd506e94ab9b5bcd5f/granite-vision-3.2-2b-Q4_K_M.gguf
0.09.578.122 W WARN: This is an experimental CLI for testing multimodal capability.
0.09.578.123 W For normal use cases, please use the standard llama-cli
the new york times |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add missing
--jinjaflag formtmd/test.sh: #23545 (comment)