ci : add approval gate to remaining workflows#23526
Conversation
Assisted-by: llama.cpp:local pi
Extend the manual approval gate to all remaining workflows: build-3rd-party, build-android, build-cache, build-cann, build-cross, build-msys, build-openvino, build-riscv, build-sanitize, build-self-hosted, build-sycl, build-virtgpu, build-vulkan, server, server-sanitize, server-self-hosted, ui-ci Note: ui-build.yml and ui-publish.yml are skipped as they are only triggered via workflow_call and inherit the gate from the caller. Assisted-by: llama.cpp:local pi
|
Massive notification spam, but ohwell... |
|
What initial rollout BTW? :) |
|
@CISC There are 2 big problems with this approach:
Not sure what to do about the notifications.
This is because I continued the branch from yesterday ggml-org#33 and didn't explain that to the bot. |
|
The new sidebar link is useful I guess, even though the filtering is not. |
|
I really can't believe there isn't a way to disable the notifications ... This is basically a showstopper for this approach. 
|
Yeah, and for years to boot... |
|
The boot would probably be simple to solve by having a dedicated self-hosted runner for the approvals. |
Sorry, that was "to boot", as in the idiom. :) It's quite unbelievable this has not been addressed in the many years it has been a feature. |
|
I imagine we will get the same spam every time a Collaborator is pushing a change as well. |
Overview
Extend the manual CI approval gate (from
approval.yml) to all remaining workflows that were missed in the initial rollout. This prevents expensive CI runs on non-master branches from executing without manual approval via theci-approvalenvironment.Covered workflows (17 files):
build-3rd-party,build-android,build-cache,build-cann,build-crossbuild-msys,build-openvino,build-riscv,build-sanitizebuild-self-hosted,build-sycl,build-virtgpu,build-vulkanserver,server-sanitize,server-self-hostedui-ciui-build.ymlandui-publish.ymlare skipped as they're only triggered viaworkflow_calland inherit the gate from their caller.Requirements