Add more wav-compatiable MIME types and enhance MIME type normalization#22744
Closed
guangchenli wants to merge 1 commit into
Closed
Add more wav-compatiable MIME types and enhance MIME type normalization#22744guangchenli wants to merge 1 commit into
guangchenli wants to merge 1 commit into
Conversation
|
@allozaur could you review this pr? |
Contributor
yes, just please rebase on latest |
Contributor
|
Superseded by #23396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue in #21850 by adding more MIME types in the check logic.
Changes
Added support to
These MIME types are common in medias generated by older audio recording and synthesis software and are binary compatiable to the standard WAV format. Current webui logic will ignore these types silently, resulting to the bug described in #21850 .
It also added a short MIME normalization logic to suppress problems caused by irregular MIME string.
How to Test
Upload a test audio file with MIME type
audio/x-wavusing the webui with a model supporting audio modality:Check if it can handle the audio file correctly: