RPC GRAPH_COMPUTE Arbitrary RCE patch#20908
Merged
rgerganov merged 1 commit intoggml-org:masterfrom Mar 23, 2026
Merged
Conversation
rgerganov
approved these changes
Mar 23, 2026
Member
rgerganov
left a comment
There was a problem hiding this comment.
I believe this check is sufficient because tensor views which are part of the compute graph are initialized by ggml_backend_view_init():
llama.cpp/ggml/src/ggml-backend.cpp
Lines 1884 to 1894 in bd69921
so it's not possible to have a valid tensor with tensor->buffer == nullptr
|
@ggerganov maybe make a new release of ggml with that fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix prevents an existing RCE chain where deserialize_tensor() skips all validations when the incoming rpce_tensor.buffer field is set to null. Currently we only check if result==null, however this does not sufficiently cover the case for result->buffer. This prevents attackers from gaining arbitrary read and write.