Add MCP Connection diagnostics and CORS hint to web-ui#20753
Closed
evalstate wants to merge 3 commits into
Closed
Conversation
allozaur
requested changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
few architectural remarks :)
To sum up, I'd suggest:
- Moving utility functions to
src/lib/utils/
api-headers.ts - Header handling:
sanitizeHeaders()redactHeaderValue()
request-helpers.ts - Request utilities:
getRequestUrl()getRequestMethod()getRequestBody()summarizeRequestBody()formatDiagnosticErrorMessage()extractJsonRpcMethods()summarizeError()getBrowserContext()getConnectionHints()
constants/ - Redacted headers list:
REDACTED_HEADERS
- Splitting tests into two files
tests/unit/utils/request-helpers.test.ts - Tests for pure utility functions
tests/unit/mcp-service.test.ts - Tests for MCPService-specific logic only
Contributor
There was a problem hiding this comment.
depending on the final shape of the code inside and outside of MCP Service class, some of these tests might need moving to separate file(s)
Contributor
|
Superseded by #21803 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds diagnostic printouts and a "check CORS" warning for Failed to Fetch scenarios when connecting to MCP Servers. Tokens etc. are redacted.
