CUDA: set_rows + cpy.cu refactor#14712
Merged
am17an merged 1 commit intoggml-org:masterfrom Jul 18, 2025
Merged
Conversation
23 tasks
JohannesGaessler
approved these changes
Jul 17, 2025
Collaborator
JohannesGaessler
left a comment
There was a problem hiding this comment.
Long-term we should rewrite the quantization code to make use of coalesced memory accesses. For an example, see quantize_q8_1 in quantize.cu, that kernel loads 32 contiguous floats and writes 32 contiguous bytes for the quantized values.
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To also support the rest of the quantized data-types in set-rows
Moving cpy functions to a common headers to re-use in set-rows, I will do get-rows next if this refactor seems the right direction. I feel we can still make the interface a little cleaner