server : (webui) let server send locally-defined default webui settings#14468
server : (webui) let server send locally-defined default webui settings#14468woof-dog wants to merge 3 commits intoggml-org:masterfrom
Conversation
ngxson
left a comment
There was a problem hiding this comment.
this is a bad UX practice because now user need to maintain a separated json file
it's better to re-design the config system and somehow re-use /props endpoint
Could you explain what you mean? Web users don't have to do anything separate. I'm not sure how to make it any easier or future-proof than letting the server operator set a json file. The json file can be located anywhere. It's no different than requiring to set their model path or mmproj file, for example. Maybe you want web users to save default settings globally within the UI?
I'll see if I can factor this into the |
|
@ngxson I updated the server/client so that it sends data through the To be clear, the llama.cpp server operator does is not required to set a default client config file. It is purely optional. For web clients hardly anything changes either except the default config before something is saved in the client's local storage. |
|
Closing this as it's superseded by #16515 |
There have been clashes, such as in #14041, with decisions about default llama.cpp client-side webui settings which are currently hardcoded and not adjustable by the
llama-serverhost without modifying source code. Here I add a command-line argument for the default JSON-encoded client-side settings which are served byllama-serverand read by the webui frontend only if no settings have been saved to local storage.Notably this means that I won't have to maintain a fork and recompile the webui frontend code manually to disable particular settings or buggy functionality (such as setting
pasteLongTextToFileLento0, helping #14041/#14251). Not all settings must be provided. For example,defaultSettings.json:
{ "pasteLongTextToFileLen": 0 }can be passed via
llama-server --default-client-config defaultSettings.json.Ultimately this gives more control back to the user to customize the server's deployment.
(And please, if there are minor issues, such as if you want to change the name of the command line flag, reviewers feel free to make changes directly.)