You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updates the documentation for the state property of slots returned by the /slots endpoint of llama-server. The documentation stated that the possible values were 0 and 1 but I was getting different values which led to me to the change in #9283
Let me know if the explanations need to be changed :)
I think it's better to report just the is_processing state instead of exposing this internal state. The problem is that we don't even know if in the future we will add or remove states (I already added one state in #10023)
In other words, slot.state is pretty much a WIP and I don't think we should expose it as a public API
Do you suggest /slots[i].state should give 0 when slot_state is 0 (internally), and 1 otherwise? Or to remove the elaboration of the other values in the documentation and just have any value > 1 represent is_processing?
Right now, I use slot.state to identify idle slots which can be used to scale up the number of client requests when the number of clients is low.
I'd suggest removing slot[i].state from the REST API and replace it with is_processing. Otherwise, it will be quite messy if slot[i].state does not match the internal slot->state.
We should also add a notice in the docs to inform that the slot data is mostly used for debugging and may have breaking changes quite often.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the documentation for the
stateproperty of slots returned by the/slotsendpoint of llama-server. The documentation stated that the possible values were0and1but I was getting different values which led to me to the change in #9283Let me know if the explanations need to be changed :)