Skip to content

Misc. bug: WebUI: Nested button elements in model selector dropdown #20832

@bluemoehre

Description

@bluemoehre

Name and Version

version: 8445 (c46583b)
built with GNU 15.2.0 for Linux x86_64

Operating systems

No response

Which llama.cpp modules do you know to be affected?

llama-server

Command line

Problem description & steps to reproduce

Currently, the cursor display/hinting no longer works correctly for the model selector dropdown.

In the final HTML I've found three levels of nested <button> elements 🥵 .
These are likely causing the browser misbehavior:

Image

Note

<button> elements must never be nested inside other <button> elements, as this can lead to event handling issues and other unexpected side effects.

Related files

https://github.com/ggml-org/llama.cpp/blob/master/tools/server/webui/src/lib/components/ui/tooltip/tooltip-trigger.svelte

https://github.com/ggml-org/llama.cpp/blob/master/tools/server/webui/src/lib/components/ui/dropdown-menu/dropdown-menu-trigger.svelte

https://github.com/bluemoehre/llama.cpp/blob/master/tools/server/webui/src/lib/components/app/models/ModelsSelector.svelte

First Bad Commit

No response

Relevant log output

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions