-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Closed
Description
Extracted the discussion from:
- llama: store mrope data in KV cell #16825 (comment)
- llama: store mrope data in KV cell #16825 (comment)
- llama: store mrope data in KV cell #16825 (comment)
In order for the bbox to be correct, I'm thinking about:
- Implement the correct
max_pixels/min_pixelsfrom the original config - Pad right/bottom corner of the image if we require to upscale (to multiple of
2*patch_size). This will guarantee that the x/y coordinates stay unchanged. But we also need to check if the original implementation actually use this strategy or not.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels