Skip to content

ggml : designate enum vals for integer types#6050

Merged
ggerganov merged 1 commit intomasterfrom
gg/ggml-type-vals
Mar 14, 2024
Merged

ggml : designate enum vals for integer types#6050
ggerganov merged 1 commit intomasterfrom
gg/ggml-type-vals

Conversation

@ggerganov
Copy link
Member

@ggerganov ggerganov commented Mar 14, 2024

Set the enum values for:

        GGML_TYPE_I8      = 24,
        GGML_TYPE_I16     = 25,
        GGML_TYPE_I32     = 26,

This avoids breaking models that store integer tensors when adding new quantization types in the future. It's too late to move them at the start of the enum as this will break all existing models

@ggerganov ggerganov mentioned this pull request Mar 14, 2024
Merged
@ggerganov ggerganov merged commit 3fe8d7a into master Mar 14, 2024
@ggerganov ggerganov deleted the gg/ggml-type-vals branch March 14, 2024 10:38
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 15, 2024
@ggerganov @NeoZhangJianyu
ggml : designate enum vals for integer types (ggml-org#6050)
58fd227
@mofosyne mofosyne added Tensor Encoding Scheme https://github.com/ggerganov/llama.cpp/wiki/Tensor-Encoding-Schemes Review Complexity : High Generally require indepth knowledge of LLMs or GPUs Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix and removed Review Complexity : High Generally require indepth knowledge of LLMs or GPUs labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix Tensor Encoding Scheme https://github.com/ggerganov/llama.cpp/wiki/Tensor-Encoding-Schemes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggerganov @mofosyne