This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Merged
Conversation
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 2 warnings, 6 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
cwfitzgerald
approved these changes
Jan 20, 2021
| use wgc::binding_model as bm; | ||
|
|
||
| let texture_view_arena: Arena<wgc::id::TextureViewId> = Arena::new(); | ||
| let mut arrayed_texture_views = Vec::new(); |
Member
There was a problem hiding this comment.
It kinda pains me to allocate this without a with_capacity on the computable max size, but it's good enough for now.
Member
Author
There was a problem hiding this comment.
Agreed! There are things to try, but they involve unsafe one way or the other.... Let's leave for a follow-up
Member
Author
|
bors r=cwfitzgerald |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumps the wgpu dependency to include gfx-rs/wgpu#1160