WGSL shader conversion for the examples#679
Conversation
There was a problem hiding this comment.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 12 warnings, 0 errors.
The .monocodus config not found in your repo. Default config is used.
Check config documentation here
64b647f to
d68868a
Compare
|
I tested all examples on develop and on this branch on Windows 10 using a RTX 2080 SUPER. Cube seems to have some coords issues: Hello triangle MipMap doesn't display They all work properly on origin/develop. I'll dig more into those later! |
|
Thanks for the force push, it solved the hello-triangle issue. |
grovesNL
left a comment
There was a problem hiding this comment.
Awesome 👍 great to see this coming along
f429e07 to
6b82d87
Compare
|
Going to land this right after #734 |
Validate example shaders in tests Support WGSL on the Web via Naga Port the shadow WGSL partially Convert hello-compute and boids to WGSL Conver the shadow's fragment shader to WGSL Shader entry point refactor
|
A little functional changes here
bors r=grovesNL |
|
Build succeeded: |
|
|
||
| // fragment shader | ||
|
|
||
| [[block]] |
There was a problem hiding this comment.
FYI. It's invalid to declare an array of block-decorated struct.
WGSL doesn't have array-of-buffers, but Vulkan SPIR-V does
There was a problem hiding this comment.
Right. At the time this was written, our [[block]] semantics was a bit different. Today, there is no [[block]] on it
wgpu-rs/examples/shadow/shader.wgsl
Line 54 in 69be1ff
Blocked on:
Link GLSL varying locations naga#335Generated SPIR-V structures are missing the offset decorations naga#336Move AdapterInfo into wgpu-types wgpu#1095[spv] emit proper member layout decorations naga#360GL backend doing the program link check earlierConverted: