Conversation
Collaborator
Author
|
I wonder 🤔 if we can/should fake float32-filterable by enabling |
Member
|
FYI bgra8 storage was really hard because it was the first to need to use a special spirv tag for storage textures. Flost32 filterable should just be some logic checks |
Collaborator
Author
Ok, you nerd-sniped me now. |
This was referenced Nov 23, 2023
Collaborator
Author
This was referenced Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The features specified by WebGPU (copied from https://gpuweb.github.io/gpuweb/#gpufeaturename):
enum GPUFeatureName { "depth-clip-control", "depth32float-stencil8", "texture-compression-bc", "texture-compression-etc2", "texture-compression-astc", "timestamp-query", "indirect-first-instance", "shader-f16", "rg11b10ufloat-renderable", "bgra8unorm-storage", "float32-filterable", };Features by wgpy-core: https://docs.rs/wgpu-types/0.18.0/wgpu_types/struct.Features.html
This PR adds one missing feature: "bgra8unorm-storage". (The "timestamp-query" was just moved so the order of the list is the same as in the spec.)
The final missing feature "float32-filterable" I cannot add because wgpu-core does not define it yet.
We are interested in having it, since we rely on it in pygfx because it's somewhat crucial in e.g. volume rendering. So I looked a bit into wgpu-core, and found the pr that adds bgra8unorm-storage. Seems like quite a bit of work, so for now I'm going to leave it at leaving the code for this feature commented here. We can keep using
TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES(which includes float32-filterable) for now. 😅