Add STRICT_WEBGPU_COMPLIANCE instance flag#9586
Merged
Merged
Conversation
b9aeac7 to
b58c67f
Compare
STRICT_WEBGPU_COMPLIANCE instance flagsSTRICT_WEBGPU_COMPLIANCE instance flag
2afbe99 to
1c2bb32
Compare
andyleiserson
approved these changes
Jun 1, 2026
andyleiserson
left a comment
Contributor
There was a problem hiding this comment.
Nice!
There is another instance flag ALLOW_UNDERLYING_NONCOMPLIANT_ADAPTER, which says it "mainly applies to a Vulkan driver's compliance version" (and that is in fact the only place it applies). It might be worth updating the docs for that flag to clarify the difference from STRICT_WEBGPU_COMPLIANCE.
It might be worth a few unit tests (maybe for adapter_allowed) capturing conditions where we don't want to return an adapter. We won't otherwise have much coverage of this logic. An expectation that adapter_allowed exists as a function, is not unused, and has certain properties, provides some protection against breakage.
1c2bb32 to
fcddc2a
Compare
`STRICT_WEBGPU_COMPLIANCE`
`STRICT_WEBGPU_COMPLIANCE`
`STRICT_WEBGPU_COMPLIANCE` is set
fcddc2a to
38ed056
Compare
andyleiserson
approved these changes
Jun 3, 2026
andyleiserson
left a comment
Contributor
There was a problem hiding this comment.
Tests look good, thanks for adding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #3274.
Fixes #9436.
Fixes #3365.
Description
Adds the
STRICT_WEBGPU_COMPLIANCEflag, intended to be used by wgpu-core users that want to strictly limit the behavior ofwgpu-coreto the one defined by the WebGPU spec.Testing
Added some more tests.
Squash or Rebase?
Rebase.
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.