Added fix and regression test for primitive id on FXC#9218
Merged
teoxoy merged 1 commit intogfx-rs:trunkfrom Mar 13, 2026
Merged
Added fix and regression test for primitive id on FXC#9218teoxoy merged 1 commit intogfx-rs:trunkfrom
teoxoy merged 1 commit intogfx-rs:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #9105
Description
Explained in the code too, but FXC treats primitive ID as a non SV so it must appear before all other SVs.
No changelog entry is required because primitive ID will be added in this release.
Testing
Tested using a regression test
Squash or Rebase?
Doesn't matter
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.