Update to winit 0.30 by cwfitzgerald · Pull Request #9089 · gfx-rs/wgpu

cwfitzgerald · 2026-02-21T08:43:51Z

Connections

Closes #5214
Closes #5722
Closes #8155

Description

This moves us entirely over to winit 0.30. This is not amazingly reviewable due to a lot of code needing to move around, but it is mainly just moving things around. If you want to review it, I would look at the new files directly.

Testing

Manual testing across platforms and on the web.

Squash or Rebase?

I think this needs to be squashed, unfortunately.

emilk · 2026-03-06T08:42:54Z

FWIW: I gave this PR a spin just to see if it affects #8309, but on my computer this PR makes no difference.

inner-daemons · 2026-03-10T05:32:17Z

@cwfitzgerald This probably warrants a copilot gh review.

Copilot

Pull request overview

This PR updates the repo to use winit 0.30 (and related ecosystem updates like glutin), and refactors examples/tools to the ApplicationHandler + resumed() window creation model required by winit 0.30.

Changes:

Bump winit to 0.30.x and update glutin/glutin-winit, removing temporary raw-window-handle 0.5 compatibility.
Refactor native + wasm examples to ApplicationHandler/run_app (and spawn_app on web), moving window creation into resumed().
Update dependency-policy configuration (.deny.toml) to reflect the new dependency graph.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`Cargo.toml`	Bumps `winit` to `0.30.8` and updates `glutin`/`glutin-winit` versions.
`Cargo.lock`	Locks updated dependency graph for the new winit/glutin versions.
`.deny.toml`	Adjusts cargo-deny skip rules for new transitive versions.
`wgpu-hal/Cargo.toml`	Removes rwh_05 compatibility deps and adjusts platform cfgs for the raw-gles example.
`wgpu-hal/examples/raw-gles.rs`	Migrates raw GLES example to `ApplicationHandler` and rwh 0.6 handle APIs.
`wgpu-hal/examples/halmark/main.rs`	Migrates example to `ApplicationHandler` and creates window in `resumed()`.
`wgpu-hal/examples/ray-traced-triangle/main.rs`	Migrates example to `ApplicationHandler` and creates window in `resumed()`.
`player/src/bin/play.rs`	Updates winit integration and window/surface creation flow for 0.30.
`examples/features/src/framework.rs`	Refactors shared example framework to `ApplicationHandler` + async init via user events.
`examples/features/src/hello_triangle/mod.rs`	Refactors hello-triangle to `ApplicationHandler` + async init via user events.
`examples/features/src/hello_windows/mod.rs`	Refactors hello-windows multi-window example to `ApplicationHandler`.
`examples/features/src/uniform_values/mod.rs`	Refactors uniform-values example to `ApplicationHandler` + async init via user events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

examples/features/src/hello_triangle/mod.rs

examples/features/src/framework.rs

examples/features/src/uniform_values/mod.rs

cwfitzgerald · 2026-03-10T05:41:20Z

Unfortunately still pretty useless

inner-daemons · 2026-03-10T05:49:30Z

Sea levels rose 0.1m so copilot could read this and leave no comments.

inner-daemons

Logic is duplicated a lot, so I didn't leave the same comments in 5 places. But many of my comments on hello_triangle or other files also apply to hello_windows, uniform_values, and the other examples.

.deny.toml

Cargo.toml

inner-daemons · 2026-03-10T06:18:18Z

examples/features/src/hello_triangle/mod.rs

+        let display_handle = event_loop.owned_display_handle();
+        let proxy = self.proxy.clone();
+
+        spawn(async move {


Maybe add a comment saying that this doesn't spawn anything on native

examples/features/src/hello_triangle/mod.rs

examples/features/src/uniform_values/mod.rs

wgpu-hal/examples/halmark/main.rs

wgpu-hal/examples/ray-traced-triangle/main.rs

player/src/bin/play.rs

examples/features/src/hello_triangle/mod.rs

inner-daemons · 2026-03-10T06:27:02Z

examples/features/src/hello_triangle/mod.rs

+
+impl ApplicationHandler<TriangleAction> for App {
+    fn resumed(&mut self, event_loop: &ActiveEventLoop) {
+        if !matches!(self.state, AppState::Uninitialized) {


framework.rs uses surface.resume(context, window.clone(), E::SRGB); here which is a fix for android I think. This skips that?

junglie85 · 2026-03-12T22:55:06Z

winit 0.31.0-beta.2 is the current version on main.

Some notable changes - there are likely more:

Window is now a trait object.
EventLoop and EventLoopProxy do not take any generic arguments.
ActiveEventLoop is now a trait object.
ApplicationHandler trait:
- introduces can_create_surface method.
- user_event is replaced with proxy_wake_up and channels.

Given that this PR is a large change, and the move to 0.31 is likely going to be another large change in a different direction, would it be wise to skip 0.30 and go straight to supporting 0.31?

cwfitzgerald · 2026-03-13T15:03:34Z

I'd rather land this incrementally - from your list the diff won't be too bad from 0.30 -> 0.31 and this had to completely restructure the examples.

inner-daemons · 2026-03-14T02:51:41Z

@Wumpf would be nice to get the examples working with winit 0.30 before the next release, if you have time.

Wumpf

reviewed it in person on a call

inner-daemons self-requested a review February 21, 2026 18:34

cwfitzgerald force-pushed the cw/winit-0.30 branch from 28f6998 to 9bbdece Compare February 22, 2026 00:24

cwfitzgerald marked this pull request as ready for review February 22, 2026 02:05

inner-daemons self-assigned this Feb 25, 2026

cwfitzgerald assigned Wumpf Feb 25, 2026

Wumpf mentioned this pull request Mar 8, 2026

macOS: Fix one-second delay when switching a wgpu app to the foreground #9141

Merged

10 tasks

cwfitzgerald requested a review from Copilot March 10, 2026 05:32

Copilot started reviewing on behalf of cwfitzgerald March 10, 2026 05:34 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

examples/features/src/hello_triangle/mod.rs Show resolved Hide resolved

examples/features/src/framework.rs Show resolved Hide resolved

examples/features/src/uniform_values/mod.rs Show resolved Hide resolved

examples/features/src/uniform_values/mod.rs Show resolved Hide resolved

inner-daemons suggested changes Mar 10, 2026

View reviewed changes

inner-daemons requested a review from Wumpf March 14, 2026 02:52

cwfitzgerald force-pushed the cw/winit-0.30 branch 4 times, most recently from aa6cda3 to 507a3e1 Compare March 18, 2026 17:14

Wumpf approved these changes Mar 18, 2026

View reviewed changes

cwfitzgerald added 4 commits March 18, 2026 13:25

Convert wgpu examples to winit 0.30

e68b1e0

Convert wgpu-hal examples to winit 0.30

9e7c990

Convert player to winit 0.30

199434e

Remove raw-gles example from openharmony

cbc5a1f

cwfitzgerald force-pushed the cw/winit-0.30 branch from 507a3e1 to cbc5a1f Compare March 18, 2026 17:25

Wumpf mentioned this pull request Mar 18, 2026

Change get_current_texture output to a unified enum #9257

Merged

6 tasks

Wumpf merged commit 2810e95 into gfx-rs:trunk Mar 18, 2026
58 checks passed

cwfitzgerald deleted the cw/winit-0.30 branch March 18, 2026 21:24

Conversation

cwfitzgerald commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emilk commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inner-daemons commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cwfitzgerald commented Mar 10, 2026

Uh oh!

inner-daemons commented Mar 10, 2026

Uh oh!

inner-daemons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inner-daemons Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inner-daemons Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

junglie85 commented Mar 12, 2026

Uh oh!

cwfitzgerald commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inner-daemons commented Mar 14, 2026

Uh oh!

Wumpf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cwfitzgerald commented Feb 21, 2026 •

edited

Loading

emilk commented Mar 6, 2026 •

edited

Loading

cwfitzgerald commented Mar 13, 2026 •

edited

Loading